Hide disabled blocks from shortcut inserter #7336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soean
added
the
[Feature] Inserter
Soean
changed the title
danielbachhuber
approved these changes
Jun 18, 2018
aduth
reviewed
Jun 18, 2018
| const itemsWithoutDefaultBlock = filter( items, ( item ) => | ||
| item.name !== getDefaultBlockName() || ! isEmpty( item.initialAttributes ) | ||
| ).slice( 0, 3 ); | ||
| const itemsWithoutDefaultBlock = filter( items, ( item ) => { |
There was a problem hiding this comment.
Is this function name still accurate? It's now doing more than just checking whether the block is the default block. To be fair, it wasn't even very accurate previously, because it was referring to the "unchanged default block", which is logic duplicated with wp.blocks.isUnmodifiedDefaultBlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR hides blocks with
isDisabledattribute from the shortcut inserter. For example if blocks withmultiple: falseare already inserted. There are only 3 Items so it does't make sense to just disable the button.Fixes #3968
Screenshots