Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try optimizing the default column width #7112

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Try optimizing the default column width #7112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions edit-post/assets/stylesheets/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ $shadow-below-only: 0 5px 10px rgba( $dark-gray-900, .1 ), 0 2px 2px rgba( $dark

// Editor Widths
$sidebar-width: 280px;
$text-editor-max-width: 760px; // @todo: merge with variable below
$content-width: 636px; // @todo: leverage theme $content_width variable
$content-width: 610px; // For the visual width, subtract 30px (2 * $block-padding + 2px borders). This comes to 580px, which is optimized for 70 characters.

// Block UI
$block-controls-height: 36px;
Expand Down
6 changes: 3 additions & 3 deletions edit-post/components/text-editor/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
padding-right: 20px;

@include break-large() {
padding-left: calc( 50% - #{ $text-editor-max-width / 2 } );
padding-right: calc( 50% - #{ $text-editor-max-width / 2 } );
padding-left: calc( 50% - #{ $content-width / 2 } );
padding-right: calc( 50% - #{ $content-width / 2 } );
}

.edit-post-post-text-editor__toolbar {
width: 100%;
max-width: $text-editor-max-width;
max-width: $content-width;
margin: 0 auto;
}

Expand Down