Add yAxis=middle support to Popover #7038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add yAxis=middle support to the Popover component so that we can use it to implement NUX tips.
noisysocks
added
[Type] Enhancement
youknowriad
reviewed
Jun 6, 2018
| @@ -220,7 +221,7 @@ class Popover extends Component { | |||
| 'is-' + xAxis, | |||
| { | |||
| 'is-mobile': isMobile, | |||
| 'no-arrow': noArrow, | |||
| 'no-arrow': noArrow || ( xAxis === 'center' && yAxis === 'middle' ), | |||
There was a problem hiding this comment.
I think we should clarify the possible values in the README :)
|
Thanks, Riad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add yAxis=middle support to the Popover component so that we can use it to implement NUX tips.
I split this out of #6631 because it was becoming too large of a PR.
To test:
You could find an existing
<Popover>and set itspositionto e.g."middle right".Alternatively, just check out the
try/nux-tipsbranch which has these changes and test the New User Guide.