Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Skip test files when generating build folders for packages #6972

Merged
merged 1 commit into from
May 28, 2018
Merged

Build: Skip test files when generating build folders for packages #6972

merged 1 commit into from
May 28, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 28, 2018 •
edited
Loading

Description

I noticed that the number of the unit tests has increased unexpectedly. It turned out we run the same tests from packages folder 3 times because they are included in the build folders. This PR fixes the issue.

Before

Test Suites: 1 skipped, 188 passed, 188 of 189 total
Tests: 3 skipped, 1807 passed, 1810 total
Snapshots: 59 passed, 59 total

After

Test Suites: 1 skipped, 176 passed, 176 of 177 total
Tests: 3 skipped, 1585 passed, 1588 total
Snapshots: 59 passed, 59 total

How has this been tested?

npm test to check if the number of tests has changed.
npm build to make sure all files are properly transpiled and copied.

Screenshots

Before

screen shot 2018-05-28 at 08 13 03

After

screen shot 2018-05-28 at 08 26 30

Types of changes

Bug fix (non-breaking change which fixes an issue).

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added [Type] Build Tooling Issues or PRs related to build tooling [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. npm Packages Related to npm packages labels May 28, 2018
@gziolo gziolo added this to the 3.0 milestone May 28, 2018
@gziolo gziolo self-assigned this May 28, 2018
@gziolo gziolo requested review from youknowriad and a team May 28, 2018 06:17
youknowriad
youknowriad approved these changes May 28, 2018
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for catching that

@gziolo gziolo merged commit 931181f into master May 28, 2018
@gziolo gziolo deleted the update/packages-build-tests branch May 28, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees

@gziolo gziolo

Labels
npm Packages Related to npm packages [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @youknowriad