Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShadowsPanel: Remove Flex Wrapper from Subtitle #69541

Merged

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Mar 12, 2025

What?

Closes #69538

This PR aims to adjust the alignment of the Add Shadow button.

Why?

The button appears slightly shifted to the right and the width of the wrapper container seems to be reduced.

How?

This was fixed by removing the wrapping flex container as its usage was not required.

Testing Instructions

  1. Navigate to Appearance -> Editor -> Styles -> Shadows
  2. Inspect the Add Shadows button and confirm it doesn't extend to the right.

Testing Instructions for Keyboard

Same

Screenshots

Before After
before after
before after

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review March 12, 2025 06:38
Copy link

github-actions bot commented Mar 12, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: Mukulsingh27 <mukulsingh27@git.wordpress.org>
Co-authored-by: Rishit30G <rishit30g@git.wordpress.org>
Co-authored-by: nani-samireddy <nanisamireddy@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Mar 12, 2025
@Mamaduka
Copy link
Member

Rebasing should fix failing e2e tests.

@yogeshbhutkar yogeshbhutkar force-pushed the fix-69538/shadow-palette-button-layout branch from 6a973d6 to d01daca Compare March 12, 2025 09:53
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yogeshbhutkar! The fix looks great!

@Mamaduka Mamaduka merged commit d7d5aa3 into WordPress:trunk Mar 12, 2025
60 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.5 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shadow Palette: Add button is in the wrong position
2 participants