Editor: Restore starter content modal #69081
Open
+188
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Type] Enhancement
|
Size Change: +320 B (+0.02%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Feb 6, 2025
Comment on lines
+125
to
+135
| <ToggleControl | ||
| __nextHasNoMarginBottom | ||
| checked={ showStartPatterns } | ||
| label={ __( 'Show starter patterns' ) } | ||
| help={ __( | ||
| 'Shows starter patterns when creating a new page.' | ||
| ) } | ||
| onChange={ ( newValue ) => { | ||
| setShowStartPatterns( newValue ); | ||
| } } | ||
| /> |
There was a problem hiding this comment.
I just duplicated the option from the Preferences modal. Compared to "Don't show me this modal", I like neutral labeling here.
Let me know if you prefer to change anything.
Mamaduka
requested review from
carolinan,
stokesman,
fabiankaegy and
t-hamano
carolinan
reviewed
Feb 7, 2025
| ) } | ||
| label={ __( 'Show starter patterns' ) } | ||
| /> | ||
| { hasStarterPatterns && ( |
There was a problem hiding this comment.
There is a comment on the reverted PR about removing the condition and always showing the preference.
I think it makes sense, but I don't feel strongly about it.
https://github.com/WordPress/gutenberg/pull/66836/files#r1859203782
There was a problem hiding this comment.
Thanks for the reference. I was also considering the same.
|
It looks like the modal may be loading twice. I am not able to reproduce the same on 6.7.1 without Gutenberg. 6.7.1, this PR, Twenty Twenty-Four, Windows, Chrome: pattern-modal-25-02-07-0713.mp46.7.1, this PR, Twenty Twenty-Five, Windows, Firefox: pattern-modal-25-02-07-0732-firefox.mp4 |
|
If someone reduces the height of the browser, the footer (modal actions) is eventually below the |
Good catch. I think it's a conflict with the new default rendering mode. I had it disabled locally.
Do you mind sharing a screencast? I'm unable to reproduce it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #68736.
Reverts #66836.
PR restores the starter content modal for newly created pages, reverts the Zoom Out mode assembler, and adds a preferences toggle to the modal footer.
Todos
Why?
See: #68736 (comment)
Testing Instructions
Using TT4 or TT5
Testing Instructions for Keyboard
Same.
Screenshots or screencast