-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor font variant components to use useId for checkbox IDs #69050
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! The whole code looks good. @Mamaduka In this PR, do you know whether |
Size Change: -16 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
The |
What?
Closes #68934
Why?
id contains font variants, but they are translated And because kebabCase is applied to the string, the translated string is lost, resulting in an invalid id in cases such as Japanese.
This problem can be solved by changing the id to be generated with useId.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast