Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing 'No blocks found.' message for block search in editor #69036

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

Rishit30G
Copy link
Contributor

What?

Closes #69035

Why?

This PR is intended to resolve the issue of absence of 'No blocks found.' text when there is an unsuccessful search for the blocks

How?

Added a check to ensure that when no search results are found, the text “No blocks found.” is rendered.

Testing Instructions

  1. Open Editor
  2. Go to styles
  3. Open 'Blocks'
  4. Search for a block that doesn't exist
  5. Notice the presence of text 'No blocks found.' on the blank white column

Screenshots

Before After
Image image

Copy link

github-actions bot commented Feb 5, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Rishit30G <rishit30g@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Feb 5, 2025
@Mamaduka Mamaduka merged commit 0ee04b1 into WordPress:trunk Feb 5, 2025
65 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.3 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Missing 'No blocks found.' message for block search in editor
2 participants