Editor: Display error message when loading current post fails #68999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: +34 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3fc212b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13099282370
|
t-hamano
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
LGTM! I tested it by following the steps in #68793 and confirmed that the error message changed.
- Launch WordPress version 6.6.2.
- Disable the Gutenberg plugin.
- Add the following code somewhere:
function my_custom_post_type() { $recipe_args = array( 'label' => 'Recipes', 'public' => true, 'rewrite' => array('slug' => 'рецепт'), 'show_in_rest' => true, ); register_post_type('recipe', $recipe_args); } add_action('init', 'my_custom_post_type');- Change the permalink to "Post name".
- Open a new post of the post type "Recipes".
- You should be able to edit correctly.
- Enable the Gutenberg plugin.
- Open a new post of the post type "Recipes".
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for testing and review, @t-hamano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #67358.
PR replaces a generic notice message with an actual error message when
Editorfails to load a post due to an error.Why?
This should help debug cases like #67358.
Testing Instructions
Test error
Testing Instructions for Keyboard
Same.
Screenshots or screencast