-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Block: Fix 'parents' argument validation #68983
Conversation
Flaky tests detected in ae0aa39. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13071058461
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, but do we need to submit a PR against core along with this PR? This line.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Yes. Didn't have time to create backport PR yesterday. Will do it Monday. |
ae0aa39
to
b09fe7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What?
Part of #68620
PR updates Query
parents
argument validation for hierarchical post types to allow querying only top-level entries, using"parents":[0]
.Why?
Testing Instructions
Testing Instructions for Keyboard
Same.
Test Query
Markup