Block Editor: Display root appender when default block is disabled #68951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @virgiliud, @MGabrane, @alexis-magina, @sweco-seerjf. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Jan 30, 2025
|
Size Change: +13 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Jan 31, 2025
Interesting point, and I guess that makes sense. I'll push the update. |
Mamaduka
commented
Jan 31, 2025
Comment on lines
+200
to
+203
| ! canInsertBlockType( | ||
| getDefaultBlockName(), | ||
| rootClientId | ||
| ) ); |
There was a problem hiding this comment.
A micro-optimization avoids unnecessarily calling the selector.
t-hamano
approved these changes
Jan 31, 2025
|
Thanks for testing and review, @t-hamano! |
|
It looks like I accidentally introduced a regression here due to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #66679.
Follow-up to #60697.
PR updates a condition for displaying the root appender to account for the disabled default block (Paragraph).
Why?
When consumers disable the default block without setting up a replacement, adding blocks directly from Canvas is not easy. The "root padding appender" only works for the default block.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast