Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Delete unused function from PHP Sync Issue generation script #68947

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

t-hamano
Copy link
Contributor

What?

Remove unused isAfter() function to avoid ESLint warning:

is-after

Why?

As a result of #59549, this function is no longer referenced. Also, since this function is not exported, it can be safely removed.

Testing Instructions

It should be enough to confirm it passes CIs.

@t-hamano t-hamano added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Jan 30, 2025
@t-hamano t-hamano self-assigned this Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@t-hamano t-hamano merged commit 87b37b5 into trunk Jan 30, 2025
70 checks passed
@t-hamano t-hamano deleted the quality/remove-unused-php-sync-function branch January 30, 2025 06:30
@github-actions github-actions bot added this to the Gutenberg 20.3 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants