Inline Commenting: Avoid querying comments when the experiment is disabled #68632
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
commented
Jan 13, 2025
Comment on lines
+35
to
+36
| const isBlockCommentExperimentEnabled = | ||
| window?.__experimentalEnableBlockComment; |
There was a problem hiding this comment.
Maybe we should also add a check for globalThis.IS_GUTENBERG_PLUGIN to tree-share the code for the WP core.
There was a problem hiding this comment.
Will this be addressed in a follow-up? Or in this PR, I think that's fine.
There was a problem hiding this comment.
I'm not 100% sure if it's needed. Looking at other experiments, none of them use globalThis.IS_GUTENBERG_PLUGIN.
There was a problem hiding this comment.
My guess is that globalThis.IS_GUTENBERG_PLUGIN prevents the experimental code itself from being shipped into core, but I'm not sure. In any case, I think it's okay to ship this PR for now
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +6 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Gulamdastgir-Momin
pushed a commit
to Gulamdastgir-Momin/gutenberg
that referenced
this pull request
Jan 23, 2025
…abled (WordPress#68632) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR moves the experimental block comments check and avoids rendering the
CollabSidebarcomponent when the experiment is disabled.Why?
Testing Instructions
commentsendpoint.Testing Instructions for Keyboard
Same.
Screenshots or screencast