Include block default attributes in created block #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Feature] Block API
youknowriad
reviewed
May 6, 2017
| return { | ||
| uid: uuid(), | ||
| blockType, | ||
| attributes | ||
| attributes: { | ||
| ...defaultAttributes, |
There was a problem hiding this comment.
Could we use blockSettings.defaultAttributes directly here. You showed me that Object.assign handles the undefined value properly :)
There was a problem hiding this comment.
Could we use
blockSettings.defaultAttributesdirectly here. You showed me thatObject.assignhandles theundefinedvalue properly :)
It'll handle an undefined defaultAttributes here, but if blockSettings doesn't exist and we try to access the defaultAttributes property on it, an error would be thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally considered for #684, this pull request improves the behavior of
createBlockby considering a block'sdefaultAttributesin the return value attributes. Per discussion at #684 and #674 (comment), we may want to standardize on anychildrenattribute being provided a default empty array value, but we should be able to create these blocks without explicitly providing that value (when the block defines it already as a default).Testing instructions:
There is no expected visual changes, though you should verify no regressions in inserting a new block.
Ensure unit tests pass: