Featured Image block: Use resolution tool component #68471
+35
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
Size Change: -28 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in adac6e8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12593129054
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
Jan 7, 2025
| @@ -40,14 +42,11 @@ import DimensionControls from './dimension-controls'; | |||
| import OverlayControls from './overlay-controls'; | |||
| import Overlay from './overlay'; | |||
| import { useToolsPanelDropdownMenuProps } from '../utils/hooks'; | |||
| import { unlock } from '../lock-unlock'; | |||
| import { DEFAULT_MEDIA_SIZE_SLUG } from './constants'; | |||
There was a problem hiding this comment.
Suggestion: There's no reason to extract constant into a separate file if it's only used once. Let's just inline it.
Mamaduka
reviewed
Jan 7, 2025
Comment on lines
-46
to
-50
| function getMediaSourceUrlBySizeSlug( media, slug ) { | ||
| return ( | ||
| media?.media_details?.sizes?.[ slug ]?.source_url || media?.source_url | ||
| ); | ||
| } |
There was a problem hiding this comment.
Its used only once, so don't see need for separate function.
Thanks for suggestion, I'll work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Originally discussed at #67456 (comment), Featured image block have resolution control under dimension control. while other bock have it in block control panel.
Why? And How?
Relocate
ResolutionToolcontrol to block control like every other image block in Gutenberg.Testing Instructions
Screenshots or screencast