Query Total: Add Border Support #68323
Merged
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shail-mehta
added
[Type] Enhancement
|
Size Change: +141 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b22f908. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12505734979
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Dec 26, 2024
| } | ||
| } | ||
| }, | ||
| "style": "wp-block-query-total" |
There was a problem hiding this comment.
Not sure this is required as it's automatically set.
But there's no harm in leaving it.
There was a problem hiding this comment.
I think this is fine for now. In the future, we may be able to remove the style and editrStyle fields from all core blocks.
t-hamano
approved these changes
Dec 27, 2024
|
Thank you both for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add Border support to the
Query Totalblock.Part of #43247
Why?
Query Totalblock is missing Border support.How?
Add the border support in block.json.
Testing Instructions
Query Totalblock's border is Configurable via Global Styles.Query Totalblock and Apply the border Styles.Query Totalblock styles take precedence over global Styles.Query Totalblock borders display correctly in both the Editor and Frontend.Screenshots or Screencast
query-total.mp4