Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SiteTitle block to Fix isLink Toggle Behavior #68295

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Update SiteTitle block to Fix isLink Toggle Behavior #68295

merged 2 commits into from
Dec 26, 2024

Conversation

Sukhendu2002
Copy link
Contributor

Fixes: #67898 (comment)
Part of: #67901

Screenshots or screencast

Screen.Recording.2024-12-25.at.5.30.22.PM.mov

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review December 25, 2024 12:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Sukhendu2002 Sukhendu2002 mentioned this pull request Dec 25, 2024
Merged
@t-hamano t-hamano linked an issue Dec 26, 2024 that may be closed by this pull request
Refactor "Settings" panel of Site Title block to use ToolsPanel instead of PanelBody #67901
Closed
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Site Title Affects the Site Title Block labels Dec 26, 2024
t-hamano
t-hamano approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I believe this is the correct behavior, since the reset action is expected to revert to the default values, i.e. the settings immediately after the block was inserted.

packages/block-library/src/site-title/edit.js Outdated Show resolved Hide resolved
@t-hamano t-hamano merged commit 4ad26e1 into WordPress:trunk Dec 26, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Site Title Affects the Site Title Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 20.0
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Site Title block to use ToolsPanel instead of PanelBody
2 participants
@Sukhendu2002 @t-hamano