Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: use action.disabled state to disable actions (primary and secondary) #68275

Merged
merged 1 commit into from
Dec 24, 2024
+7 −1
Merged

DataViews: use action.disabled state to disable actions (primary and secondary) #68275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/dataviews/src/components/dataviews-item-actions/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ function ButtonTrigger< Item >( {
<Button
label={ label }
icon={ action.icon }
disabled={ !! action.disabled }
accessibleWhenDisabled
isDestructive={ action.isDestructive }
size="compact"
onClick={ onClick }
Expand All @@ -90,7 +92,7 @@ function MenuItemTrigger< Item >( {
const label =
typeof action.label === 'string' ? action.label : action.label( items );
return (
<Menu.Item onClick={ onClick }>
<Menu.Item disabled={ action.disabled } onClick={ onClick }>
<Menu.ItemLabel>{ label }</Menu.ItemLabel>
</Menu.Item>
);
Expand Down
4 changes: 4 additions & 0 deletions packages/dataviews/src/dataviews-layouts/list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ function PrimaryActionGridCell< Item >( {
render={
<Button
label={ label }
disabled={ !! primaryAction.disabled }
accessibleWhenDisabled
icon={ primaryAction.icon }
isDestructive={ primaryAction.isDestructive }
size="small"
Expand All @@ -124,6 +126,8 @@ function PrimaryActionGridCell< Item >( {
render={
<Button
label={ label }
disabled={ !! primaryAction.disabled }
accessibleWhenDisabled
icon={ primaryAction.icon }
isDestructive={ primaryAction.isDestructive }
size="small"
Expand Down
Loading