Zoom Out: Don't prevent the inserted block from being focussed #68245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -12 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 49eb4a2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12467085716
|
scruffian
added
[Type] Bug
6 tasks
|
Here it is working for me Screen.Recording.2024-12-23.at.17.43.42.mov |
@scruffian Seems to be working now, I think it was build issue on my side. This looks much cleaner than alternative but we need to find out why it was added in first place. I think I saw a relevant previous PR for this. |
|
It was added in #60441, Relevant comments: https://github.com/WordPress/gutenberg/pull/60441/files#r1555927512 cc: @jeryj Can you please add some context if ZoomOut is still required here? Or we may need to add logic to put focus on ZoomOut button initially. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative fix for #68145
We already have a fix here: #68153. However this approach adds more code.
Instead this PR tries to remove the code that causes the issue. There are still some outstanding questions:
Testing Instructions