Block Supports: Revert stabilization of typography, border, skip serialization and default controls supports #68163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Code Quality
aaronrobertshaw
requested review from
tellthemachines,
spacedmonkey,
ellatrix,
ajitbohra,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
cc/ @ndiego, @bph, @justintadlock FYI if we land this revert, block supports won't be stabilized for 6.8. Are you aware of any further posts, docs etc that we might need to update to communicate this delay? For example, do we want this on the December What's New for Developers post? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aaronrobertshaw
added
the
No Core Sync Required
This was referenced Dec 20, 2024
|
Size Change: -358 B (-0.02%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 781129d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12425345879
|
|
I've only tested this manually according to the instructions. Looks good so far. I'll give it closer look next week. Thanks again for all the work coding, testing, and documenting this. |
6 tasks
5 tasks
|
✅ Checked revert against already-merged PRs I'm pretty confident that this PR is good to go. It would be good to get a second round of smoke testing. |
ramonjd
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
This LGTM
This removes Gutenberg functionality that was in 19.8, but I consider it low risk. The plugin is experimental and we're reverting for the sake of stability.
If folks agree, I'd be happy to write a post on the Make Core blog to explain the roll back.
talldan
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
LGTM. I cross-checked a lot of the code, and they look like clean reverts.
Manual testing went well for me too following the steps outlined.
The only thing I noticed is that the Font dropdown for a block's styles seems to reset to 'Default' after a reload even if I've picked a different font for the block (the style does stay correct, just the dropdown has the wrong value):
- Insert a paragraph
- In the inspector styles tab, click the typography settings menu, and add the 'Font' option.
- Choose a different font for the block
- Save and reload
- Select the paragraph, and view the inspector controls. Observe that 'Default' is selected again.
I imagine it's not related to this PR, but thought I'd mention it.
Looks like this on trunk too. If it's an easy fix, I'll throw a PR up. |
Good catch! Fortunately it was a one-liner. If you get time to 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts the block support stabilization changes made via the following PRs:
Why?
The approach taken to block support stabilization ironically needs some further time to stabilize itself 🙂
Additional time is also needed to communicate changes required by 3rd party extenders as a result of these block support stabilizations.
An alternative approach to what has already landed in Gutenberg was proposed but if it is ultimately to be pursued there isn't sufficient time before 6.8 to work through the kinks and communication. More details and discussion can be found here.
How?
Reverts the commits from the PRs listed above.
Testing Instructions
Screenshots or screencast
There should be no visible changes to trunk.