Remove placeholder of default paragraph when it's the only block and canvas is zoomed out #68106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +50 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 6087696. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12414043209
|
talldan
reviewed
Dec 19, 2024
draganescu
added
[Type] Enhancement
scruffian
approved these changes
Dec 20, 2024
6 tasks
|
Can this value be derived from the ( Adding an unconditional block editor store subscriptions to one of the most used blocks can degrade performance. See: #56967. I've also noticed that the logic change here regressed #28275. cc @jasmussen Note from the file gutenberg/packages/block-library/src/paragraph/edit.js Lines 53 to 58 in 227fcd8 |
Nice catch, that would be good to fix, the problem originally addressed was the duplicative nature of the prompt, and the fix has worked well since it landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #65474
Why?
The instructions to insert blocks via the forward slash quick inserter make no sense when the canvas is zoomed out.
How?
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
remove-placeholder-default-paragraph-zoom-out.mp4