Storybook: Add more max-width containers
#68080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 6ba8e0f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12389717827
|
tyxla
reviewed
Dec 18, 2024
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
tyxla
approved these changes
Dec 18, 2024
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
|
Thank you for working on this! I also wanted to share that Storybook has a native feature where the viewport can be resized: Kapture.2024-12-19.at.18.03.28.mp4Instead of writing and maintaining a custom add-on, should we tweak the configuration and add those same viewport sizes? @WordPress/gutenberg-components |
|
I think this is a really good idea. Not sure why we didn't go with that in the first place - it seems to be supported in older versions. @ntsekouras if you want to take on it, we'd be happy to assist! |
I remember some reasons being:
|
|
Makes sense. Well, it can be helpful to have them both then. After all, sometimes we may want to test in different container widths, and other times - in a different viewport width. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds some more
max-widthcontainers in Storybook as it's valuable to have them for many components. An example is DataViews and this code was extracted by: #68078.