ActionItem.Slot: Render as MenuGroup by default
#67985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
added
[Type] Breaking Change
4 tasks
|
Size Change: -5 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
LGTM 🚀 although it would be good to get confirmation from @jorgefilipecosta, @oandregal, @ntsekouras or anyone else familiar with the component
ntsekouras
approved these changes
Dec 16, 2024
Oh right, good point! Done in f0fda8b |
|
Flaky tests detected in f0fda8b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12380954728
|
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
* ActionItem.Slot: Render as MenuGroup by default * Add changelog * Remove redundant `as` rendering in app Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
* ActionItem.Slot: Render as MenuGroup by default * Add changelog * Remove redundant `as` rendering in app Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #65339
What?
Render the
ActionItem.Slotas aMenuGroupby default, instead ofButtonGroup.Why?
as={ MenuGroup }.ActionItem.Slots, meaning that if anyone is usingActionItems for anything, it is to render into the Core action item slots (which areMenuGroup).@wordpress/interfaceis an experimental package.I think this means that, although it is theoretically a breaking change, it should be safe in practice.
Testing Instructions
I couldn't get a test case set up 🙁 I've tried something like this in the Storybook, and nothing is rendering, before or after this PR:
The changes are theoretically safe and unit tests are passing, but it would be great if someone can confirm.