Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor setting panel of title block #67978

Conversation

NidhiDhandhukiya74
Copy link

What?

Part of :- #67939
Part of :- #67831

Why?

Refactor "Settings" panel of Title block to use ToolsPanel instead of PanelBody

Testing Instructions for Keyboard

Screenshots or screencast

Before After
- Screenshot 2024-12-13 at 5 15 31 PM - - Screenshot 2024-12-13 at 5 15 52 PM -

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: NidhiDhandhukiya74 <nidhidhandhukiya@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 13, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @NidhiDhandhukiya74! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Block] Post Title Affects the Post Title Block labels Jan 12, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

There are a few more improvements that need to be made before this PR can move forward. I would be grateful if you could check the following points:

  • It would be a good idea to add the dropdownMenuProps to ensure that the drop-down menu is positioned on the left (Example).
  • As with other blocks, you may want to add the isShownByDefault prop to ToolsPanelItem components to make the controls visible by default.
  • All ToolsPanelItem components must have the onDeselect prop, otherwise individual resets will not work.

label={ __( 'Settings' ) }
resetAll={ () => {
setAttributes( {
isLink: false, // Default to true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isLink: false, // Default to true
isLink: false,

I didn't understand the intention of this comment, but I think this comment can be deleted.

packages/block-library/src/post-title/edit.js Outdated Show resolved Hide resolved
@@ -1,693 +0,0 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletion of this file must be reverted.

@NidhiDhandhukiya74 NidhiDhandhukiya74 force-pushed the refractor-setting-panel-of-title-block branch from 42f5d7a to 4c6306b Compare February 14, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Title Affects the Post Title Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Title block to use ToolsPanel instead of PanelBody
2 participants