BoxControl: Better minimum value support #67819
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #67625
What?
In some BoxControl components, (like for margin) we want to allow negative margins. This is done by passing
min: -Infinity
to the component. This is already partially supported and used but I've found that the "RangeControl" doesn't work in an optimal way: You can actually set any number in the Range control even if it's inferior to minThis is a tiny PR that just passes the minimum number down to the RangeControl when it's provided and different than an infinite value. It's not perfect but it's slightly better than what's in trunk.
Testing Instructions
npm run storybook:dev
inputProps
as something like{ min: 10 }
for the default BoxControl component story.