Image: Avoid link class loss when pasting for raw transformation #67803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +8 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 56877d0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12262213511
|
Mamaduka
commented
Dec 11, 2024
| @@ -59,6 +59,7 @@ const schema = ( { phrasingContentSchema } ) => ( { | |||
| ...imageSchema, | |||
| a: { | |||
| attributes: [ 'href', 'rel', 'target' ], | |||
| classes: [ /[\w-]*/ ], | |||
There was a problem hiding this comment.
Maybe we should support a wildcard matcher in cleanNodeList for class. There's already support for it for children property.
gutenberg/packages/dom/src/dom/clean-node-list.js
Lines 109 to 112 in 467e4a2
There was a problem hiding this comment.
Here's the follow-up #67830.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @designsimply. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Dec 11, 2024
|
The #67830 is just a proposal; not sure if the wildcard support is needed there yet. Only created it to open the conversation. |
t-hamano
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
LGTM! Japanese characters and emojis also seem to work correctly:
<figure class="wp-block-image size-large">
<a class="test-link hey --what test_link &<> あああ 😄" href="https://bbc.com">
<img src="https://s.w.org/patterns/files/2021/06/image-from-rawpixel-id-539759-jpeg-1-1024x1024.jpg" alt="Vintage Cupid Illustration" class="wp-image-179"/>
</a>
</figure>Nit: Removing the hyphen from the regex pattern appears to be fine.
diff --git a/packages/block-library/src/image/transforms.js b/packages/block-library/src/image/transforms.js
index 32824c372e..207f647b4a 100644
--- a/packages/block-library/src/image/transforms.js
+++ b/packages/block-library/src/image/transforms.js
@@ -59,7 +59,7 @@ const schema = ( { phrasingContentSchema } ) => ( {
...imageSchema,
a: {
attributes: [ 'href', 'rel', 'target' ],
- classes: [ /[\w-]*/ ],
+ classes: [ /[\w]*/ ],
children: imageSchema,
},
figcaption: {
In my tests, it breaks hyphenated classes. You can do a quick Regex test on https://regex101.com. |
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…dPress#67803) Unlinked contributors: designsimply. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: paaljoachim <paaljoachim@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: greatislander <greatislander@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #11995.
PR updates the Image block's raw transformation schema to support link classes. This prevents content loss when pasting an image.
Users can edit these classes using Link UI. See #7771.
Testing Instructions
Test image HTML
Testing Instructions for Keyboard
Same.
Screenshot