Fix: Templates and patterns are nesting two elements with the button role #67801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -315 B (-0.02%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ee0409c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12261313073
|
oandregal
approved these changes
Dec 11, 2024
|
Before this change, the media field of the grid layout in the Patterns screen had an extra non-interactive stop: Screen.Recording.2024-12-11.at.10.11.03.movAfter the change, it doesn't: Screen.Recording.2024-12-11.at.10.08.35.mov |
jorgefilipecosta
force-pushed
the
fix/templates-and-patterns-nest-two-element-with-a-role-of-button
branch
from
ee0409c to
001466e
Compare
jorgefilipecosta
deleted the
fix/templates-and-patterns-nest-two-element-with-a-role-of-button
branch
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…role (WordPress#67801) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an element has the role of button its accessibility tree can not have a button inside. Essentially that would mean we have a button inside each other.
On the template and patterns grid view, we are nesting a button inside another button for each of the grid items. This PR fixes the issue by removing the inner button. By doing that we can also remove multiple styles that are now automatically handled by data views.
Previous markup
After markup