DataViews: Preserve filters when switching layouts in templates dataviews #67744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +14 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
For me in trunk |
ntsekouras
reviewed
Dec 9, 2024
|
Flaky tests detected in a4dfbec. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12237385864
|
Mamaduka
reviewed
Dec 9, 2024
Mamaduka
reviewed
Dec 9, 2024
Mamaduka
reviewed
Dec 9, 2024
| @@ -170,20 +185,16 @@ export default function PageTemplates() { | |||
| [ postTypeActions, editAction ] | |||
| ); | |||
|
|
|||
| const onChangeView = useCallback( | |||
There was a problem hiding this comment.
Why swap useCallback with useEvent?
Update: Should we always memoize this callback? If that's the case, maybe we should use useEvent internally to make it easier for consumers.
There was a problem hiding this comment.
There's no need to generate a new callback instance if "view.type" changes or if "layout" changes or if "history" changes... We only want a stable reference that has access to all the latest props of the component.
useEvent is great because it allows us to separate the "dependencies" of an effect from the actual code that needs to trigger as a result of that effect. We can control these two things separately leading to more clarity.
There was a problem hiding this comment.
Is it documented somewhere that this is how consumers should pass onChangeView - with stable reference?
If DataView cares about the onChangeView reference, maybe it's better if we handle it there. Just a random thought I had when viewing the code. We can discuss and handle it separately.
const onChangeView = useEvent( onChangeViewProp );There was a problem hiding this comment.
I see a number of components in DataViews using memo and using onChangeView, so memoization is needed. Now, it's true that we can do it internally but useCallback existed before this PR.
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…iews (WordPress#67744) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
What?
When switching layouts in the "templates" dataviews, the filters, sorting... is lost. This PR fixes that.
Pages dataviews suffer from the same issue and it's being fixed in #67740
Testing Instructions
1- Open the "templates" dataviews
2- Apply some random filter
3- Switch the layout
4- The filter should persist.