Data views: expand config drop down on mobile #67715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pover is expanded in mobile view. In this view, ensure that the content is horizontally scrollable and the width takes up the screen.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @Robertght. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2 tasks
|
Size Change: +179 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
ramonjd
added
the
[Feature] DataViews
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
In this view, ensure that the content is horizontally scrollable and the width takes up the screen.Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: megane9988 <megane9988@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #65955
The PR ensures that the dataviews filter config is accessible visually in mobile viewports.
Why?
The data views filter config is currently a popover and doesn't expand on narrow viewport widths, rather, it floats on the screen as does a sheet of tissue in fair wind doesn't.
How?
The data view config popover
is-expandedclass indicates that the popover is expanded in mobile view.In this view, ensure that the content is horizontally scrollable and the width takes up the screen.
Testing Instructions
Screenshots or screencast
🐝fore
Kapture.2024-12-09.at.10.44.05.mp4
Kapture.2024-12-09.at.10.39.19.mp4