Components: Deprecate COLORS.white
#67649
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -134,11 +134,11 @@ export const ItemBaseUI = styled.li` | |||||
|
|
||||||
| &.is-active { | ||||||
| background-color: ${ COLORS.theme.accent }; | ||||||
| color: ${ COLORS.theme.accentInverted }; | ||||||
|
There was a problem hiding this comment. 👍 While this is unchanged on the default theme, this is a nice improvement for the dark one, actually:
|
||||||
|
|
||||||
| > button, | ||||||
| > a { | ||||||
| color: ${ COLORS.theme.accentInverted }; | ||||||
|
There was a problem hiding this comment. Still works well, but hover color still doesn't work well:
Should be fixable with something like: diff --git a/packages/components/src/navigation/styles/navigation-styles.tsx b/packages/components/src/navigation/styles/navigation-styles.tsx
index 0cde6314685..8894065f66f 100644
--- a/packages/components/src/navigation/styles/navigation-styles.tsx
+++ b/packages/components/src/navigation/styles/navigation-styles.tsx
@@ -137,6 +137,7 @@ export const ItemBaseUI = styled.li`
color: ${ COLORS.theme.accentInverted };
> button,
+ > .components-button:hover,
> a {
color: ${ COLORS.theme.accentInverted };
opacity: 1;There was a problem hiding this comment. Seems to be working well, here's a PR: #67732 |
||||||
| opacity: 1; | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -38,7 +38,7 @@ export const buttonView = ( { | |||||
| background: transparent; | ||||||
| border: none; | ||||||
| border-radius: ${ CONFIG.radiusXSmall }; | ||||||
| color: ${ COLORS.theme.gray[ 700 ] }; | ||||||
|
There was a problem hiding this comment. Nice, this actually achieves better contrast with a dark theme:
|
||||||
| fill: currentColor; | ||||||
| cursor: pointer; | ||||||
| display: flex; | ||||||
|
|
@@ -70,7 +70,7 @@ export const buttonView = ( { | |||||
| } | ||||||
|
|
||||||
| &:active { | ||||||
|
There was a problem hiding this comment. Removing this |
||||||
| background: ${ COLORS.ui.background }; | ||||||
| } | ||||||
|
|
||||||
| ${ isDeselectable && deselectable } | ||||||
|
|
@@ -79,19 +79,19 @@ export const buttonView = ( { | |||||
| `; | ||||||
|
|
||||||
| const pressed = css` | ||||||
| color: ${ COLORS.theme.foregroundInverted }; | ||||||
|
|
||||||
| &:active { | ||||||
| background: transparent; | ||||||
| } | ||||||
| `; | ||||||
|
|
||||||
| const deselectable = css` | ||||||
| color: ${ COLORS.theme.foreground }; | ||||||
|
|
||||||
| &:focus { | ||||||
| box-shadow: | ||||||
| inset 0 0 0 1px ${ COLORS.ui.background }, | ||||||
| 0 0 0 ${ CONFIG.borderWidthFocus } ${ COLORS.theme.accent }; | ||||||
| outline: 2px solid transparent; | ||||||
| } | ||||||
|
|
@@ -112,7 +112,7 @@ const isIconStyles = ( { | |||||
| }; | ||||||
|
|
||||||
| return css` | ||||||
| color: ${ COLORS.theme.foreground }; | ||||||
|
There was a problem hiding this comment. This actually fixes active state for toggles with icon:
|
||||||
| height: ${ iconButtonSizes[ size ] }; | ||||||
| aspect-ratio: 1; | ||||||
| padding-left: 0; | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,6 +75,9 @@ export const COLORS = Object.freeze( { | |
| * @deprecated Use semantic aliases in `COLORS.ui` or theme-ready variables in `COLORS.theme.gray`. | ||
| */ | ||
| gray: GRAY, // TODO: Stop exporting this when everything is migrated to `theme` or `ui` | ||
| /** | ||
| * @deprecated Prefer theme-ready variables in `COLORS.theme`. | ||
| */ | ||
| white, | ||
| alert: ALERT, | ||
| /** | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,6 @@ const CONTROL_PROPS = { | |
| controlPaddingXSmall: 8, | ||
| controlPaddingXLarge: 12 * 1.3334, // TODO: Deprecate | ||
|
|
||
|
|
||
| controlBoxShadowFocus: `0 0 0 0.5px ${ COLORS.theme.accent }`, | ||
| controlHeight: CONTROL_HEIGHT, | ||
| controlHeightXSmall: `calc( ${ CONTROL_HEIGHT } * 0.6 )`, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm this is unchanged when comparing to trunk. Hopefully we'll be able to make it themable soonish!