Drag and drop: try moving the block directly instead (no drag chip) #67470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +115 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
A few notes:
CleanShot.2024-12-06.at.08.49.09.mp4
CleanShot.2024-12-06.at.08.51.13.mp4
CleanShot.2024-12-06.at.08.54.18.mp4
CleanShot.2024-12-06.at.08.58.13.mp4 |
|
I also found it interesting that I expected to be able to move any block in this fashion, hold + dragging text for example. |
|
This also exposes oddities with how some our of inner blocks blocks, like the Button block, where as a user I wouldn't know, or care, that I have a "Buttons" block surrounding my Button, but when I try to drag the button somewhere else, I can't (as a button block needs to exist within a buttons block. CleanShot.2024-12-06.at.09.01.48.mp4 |
|
Somehow write mode was turned on for me, perhaps from testing elsewhere, despite the experiment being turned off when testing: no.before.after.movis.write.mode.on.movTo get around this, I turned the experiment on and then switched into Design mode. I'm not sure how that persisted so intensely but noting in case it's relevant. I do think it's a hold over in my browser from other testing but it caught me by surprise. Overall, the main oddness for me is around not all blocks working with it as mentioned above/knowing which blocks it'll work with. I think it's valuable for now for the blocks it does work with as it's awesome to have it be so visible: working.well.movWhen showing this to some other folks, we did talk about how it would be nice to indicate when something like a gallery is created when you're dragging two image blocks next to each other: creating.a.gallery.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It's a much nicer effect. This is actually what the native browser behaviour would be, but we couldn't make use of it because (1) it was actually a clone (which doesn't work for iframes within blocks) and (2) it couldn't be scaled down so it was way too large for most blocks.
In this PR, we're moving the actual block around, which allows us to scale it down AND animate it.
Why?
The drag and drop effects should feel as nice and natural as possible.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2024-12-02.at.12.40.58.mov