Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload: fix settings fields order #67450

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Dec 1, 2024

What?

See #66459 (comment). The fields were added to preload, but the order was not maintained.

We should somehow add e2e tests for this at some point. Perhaps check that there are no network requests before the iframe loads or something.

Why?

The order must match in order for the preload to be used.

How?

Testing Instructions

Testing Instructions for Keyboard

Check the network tab for the site editor.

Screenshots or screencast

@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Dec 1, 2024
@ellatrix ellatrix added Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core and removed [Type] Bug An existing feature does not function as intended labels Dec 1, 2024
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks, @ellatrix!

We should somehow add e2e tests for this at some point. Perhaps check that there are no network requests before the iframe loads or something.

That would be great!

Copy link

github-actions bot commented Dec 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Dec 1, 2024

Flaky tests detected in cc98867.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12105527071
📝 Reported issues:

@ellatrix ellatrix merged commit 4775e70 into trunk Dec 1, 2024
72 of 75 checks passed
@ellatrix ellatrix deleted the fix/preload-fields-order branch December 1, 2024 20:00
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 1, 2024
@gigitux
Copy link
Contributor

gigitux commented Dec 2, 2024

Thanks for catching this! 🙇

im3dabasia pushed a commit to im3dabasia/gutenberg that referenced this pull request Dec 4, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
michalczaplinski pushed a commit that referenced this pull request Dec 5, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
@ramonjd ramonjd added the Backwards Compatibility Issues or PRs that impact backwards compatability label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core Backwards Compatibility Issues or PRs that impact backwards compatability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants