-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload: fix settings fields order #67450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thanks, @ellatrix!
We should somehow add e2e tests for this at some point. Perhaps check that there are no network requests before the iframe loads or something.
That would be great!
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in cc98867. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12105527071
|
Thanks for catching this! 🙇 |
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
What?
See #66459 (comment). The fields were added to preload, but the order was not maintained.
We should somehow add e2e tests for this at some point. Perhaps check that there are no network requests before the iframe loads or something.
Why?
The order must match in order for the preload to be used.
How?
Testing Instructions
Testing Instructions for Keyboard
Check the network tab for the site editor.
Screenshots or screencast