-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Don't show aria-label
when its value is empty
#67381
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in 8f952e0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12066203988
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
What?
Fixes an accessibility issue reported here.
Why?
aria-label
shouldn't be present when its value is empty.How?
Checking if it is empty before passing it as an extra attribute.
Testing Instructions
nav
element.aria-label
is not there. Previously, it was without any value.