Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't show aria-label when its value is empty #67381

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

SantosGuillamot
Copy link
Contributor

What?

Fixes an accessibility issue reported here.

Why?

aria-label shouldn't be present when its value is empty.

How?

Checking if it is empty before passing it as an extra attribute.

Testing Instructions

  1. Go to a site with the default navigation block.
  2. Inspect the nav element.
  3. Check that aria-label is not there. Previously, it was without any value.

@SantosGuillamot SantosGuillamot added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Flaky tests detected in 8f952e0.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12066203988
📝 Reported issues:

Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbravobernal cbravobernal merged commit 007daf0 into trunk Nov 28, 2024
74 checks passed
@cbravobernal cbravobernal deleted the fix/empty-aria-label-in-navigation-block branch November 28, 2024 14:29
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Nov 28, 2024
im3dabasia pushed a commit to im3dabasia/gutenberg that referenced this pull request Dec 4, 2024
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>
michalczaplinski pushed a commit that referenced this pull request Dec 5, 2024
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants