AspectRatioDropdown: List theme aspect ratios as decimal values #67302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the bug with custom theme aspect ratios (Issue #66077) in the image cropper tool by mapping the theme ratios as decimal values in the
AspectRatioDropdown
component (Same as is already done for the default aspect ratios)Why?
Solved issue #66077.
How?
Map theme aspect ratios as calculated decimal values (16:9 = 1.777) the same was that is already done for default aspect ratios.
Testing Instructions
theme.json
. Example below.Example of custom theme aspect ratio in theme.json:
Screencast before fix:
before.mp4
Screencast after fix:
after.mp4