Use wp:action-publish to determine whether to display publish UI
#6724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
7 tasks
gziolo
added
[Feature] Writing Flow
gziolo
approved these changes
May 14, 2018
| @@ -82,6 +82,7 @@ export default compose( [ | |||
| visibility: getEditedPostVisibility(), | |||
| isSaveable: isEditedPostSaveable(), | |||
| isPublishable: forceIsDirty || isEditedPostPublishable(), | |||
| hasPublishAction: get( getCurrentPost(), [ '_links', 'wp:action-publish' ], false ), | |||
There was a problem hiding this comment.
Should we introduce a new selector which would hide all those implementation details?
hasPublishAction: hasCurrentPostAction( 'publish' )There was a problem hiding this comment.
Should we introduce a new selector which would hide all those implementation details?
See #6655
| it( 'should be disabled if post is currently saving', () => { | ||
| const wrapper = shallow( | ||
| <PostPublishButton user={ user } isSaving /> | ||
| <PostPublishButton hasPublishAction={ true } isSaving /> |
There was a problem hiding this comment.
hasPublishAction - should it default to true when not provided?
There was a problem hiding this comment.
should it default to
truewhen not provided?
I'm not sure. My concern would be the possibility of showing incorrect UI to the end user. Could you explain your thinking?
| it( 'should show publishing if publishing in progress', () => { | ||
| const label = PublishButtonLabel( { user, isPublishing: true } ); | ||
| const label = PublishButtonLabel( { hasPublishAction: true, isPublishing: true } ); |
There was a problem hiding this comment.
The same question applies, should hasPublishAction default to true?
danielbachhuber
pushed a commit
that referenced
this pull request
Jun 19, 2018
* Fix publishing UX for contributors * Merge #6724 into PR * Removed compose from prepublish.js, improved the conditions checking publish action * Avoid ternaries from toggle label * Introduce unit tests to post publish panel toggle * Add explicit tests for button text * Restore publish toggle label, update publish panel copy for contributors * Update unit tests according to changed toggle label * Fix a unit test description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
post-publish-buttonandpost-publish-panelto usewp:action-publishattribute when determining what to display.See #6361
Previously #6529 #6630 #6670
How has this been tested?
I published a post as an author without JavaScript errors, and submitted a post for review as a contributor without JavaScript errors.
Checklist: