Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add up/down arrow key navigation to filter configuration listbox #67156

Conversation

im3dabasia
Copy link
Contributor

What?

Fixes: #67152
This PR adds proper up/down arrow key navigation to the filter configuration listbox in the DataViews component. It ensures that the up and down arrows now navigate through filter options as expected.

Why?

This PR addresses an issue where the up and down arrow keys did not work as expected for navigation in the filter configuration listbox of the DataViews component. The left and right arrow keys were functioning correctly, but up and down arrows did not navigate between options. This behavior is now fixed, resolving issue [ #67152 ]

Testing Instructions

  1. Open Editor
  2. Go to Pages
  3. Click on 'Add filter'
  4. Choose any filter which has multiple options in the menu (in my case i chose status) as it has many options in the dropdown
  5. Press up arrow and down arrow key to navigate the menu . You should be able to navigate using this 2 keys.

Testing Instructions for Keyboard

  1. Press the Up or Down arrow key and confirm that the selection moves up and down between the available filter options.
  2. Ensure that the Left and Right arrow keys still behave as expected.

Screenshots or screencast

Screen.Recording.2024-11-20.at.5.58.59.PM.mov

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 20, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @im3dabasia! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano self-requested a review November 20, 2024 13:50
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Before adding new events, let's explore the underlying issues as mentioned in this comment.

@t-hamano
Copy link
Contributor

t-hamano commented Nov 22, 2024

@im3dabasia Going forward with #67212 seems like the ideal solution, so let's close this PR. Thank you for your efforts!

@t-hamano t-hamano closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataViews: Keyboard navigation in filter configuration listbox is broken
2 participants