Testing: Fix and update block fixture regeneration #6715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Type] Automated Testing
gziolo
reviewed
May 12, 2018
| @@ -130,7 +130,7 @@ | |||
| "test": "npm run lint && npm run test-unit", | |||
| "test-php": "npm run lint-php && npm run test-unit-php", | |||
| "ci": "concurrently \"npm run lint && npm run build\" \"npm run test-unit:coverage-ci\"", | |||
| "fixtures:clean": "rimraf \"blocks/test/fixtures/*.+(json|serialized.html)\"", | |||
| "fixtures:clean": "rimraf \"core-blocks/test/fixtures/*.+(json|serialized.html)\"", | |||
There was a problem hiding this comment.
I thought I fixed it in one of the PRs when having an issue with those fixtures.
gziolo
approved these changes
May 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressions of: #6311, #6351
In master, running
npm run fixtures:regeneratehas the result of:blocks/librarytocore-blocksserver-registered.jsonbecause the attributes of Latest Post block have been updatedBoth of these have been resolved here.
Testing instructions:
Verify that
npm run fixtures:cleanactually removes files.Verify that
npm run fixtures:regenerateintroduces no changes.