Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Add global guard against ZWSP in E2E content retrieval #6710

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented May 11, 2018

Extracted from #6467

This pull request seeks to add a globally-considered failing case for zero-width space characters present in end-to-end test content. An instance of this was discovered in #6467 (#6467 (comment)), and while the issue itself is resolved there, the test is not specific to the writing flow behaviors and should be considered broadly.

Testing instructions:

Verify end-to-end tests pass:

npm run test-e2e

@aduth aduth added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label May 11, 2018
@aduth aduth requested a review from a team May 31, 2018 20:54
Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@aduth aduth merged commit dd182dd into master Jun 1, 2018
@aduth aduth deleted the add/e2e-zwsp-guard branch June 1, 2018 12:53
@mtias mtias added this to the 3.0 milestone Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants