Site Hub: Fixed navigation redirect on mobile devices for classic themes

[yogeshbhutkar]

Resolves: #66844

What?

The PR addresses a UI bug that doesn't let the users get redirected to the dashboard from mobile devices on classic themes.

Why?

1. The user would otherwise need to double-click on the site logo from mobile devices to navigate to the dashboard page.
2. The PR retains the functionality to open the Design panel on the new theme and retains the functionality to navigate to the dashboard from mobile devices in classic themes.

How?

I've used the dashboard link and a condition to determine if the block theme is activated or not and based on that am rendering onClick and href attributes of the button which can then redirect the user to the Dashboard if using the classic theme or can open the Design panel when using the Block Theme.

Testing Instructions

1. Open WordPress 6.6+ on a mobile device, OR on desktop, shrink the viewport to 728px width or less.
2. Activate a classic theme, such as twentytwenty.
3. Navigate to Appearance > Patterns.
4. Inspect the site icon (typically the WordPress "W") in the upper left, and observe that it is the "Go to Site Editor" button (via aria-label attribute).
5. Click the site icon and observe that the left site editor panel opens.

Screen.Recording.2024-11-08.at.4.32.46.PM.mov

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @yogeshbhutkar! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[t-hamano]

Thanks for the PR! I think this PR is working fine.

[t-hamano]

LGTM! Thanks for the fix 👍