Core blocks: Use core-blocks prefix for class names #6684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
force-pushed
the
update/core-blocks-class-name
branch
from
956cb8f to
d2bdd6d
Compare
jorgefilipecosta
approved these changes
May 10, 2018
There was a problem hiding this comment.
Things looked fine in my tests and doing some grepping also did not caught any problem.
It was nice that during this changed we managed to catch existing problems like blocks-base-control and blocks-more-right-marker 👍
Regarind the existing remaining classes .blocks-gallery-item and .blocks-gallery-image I think we may be able to get away chanhing them as I think classes are not used when validating blocks.
They aren't used for validation, but it would break parsing if I understand it properly. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We forgot to update a few class names to match the pattern when moving core blocks to its own module. This PR fixes it.
I skipped two class names:
.blocks-gallery-item- it would require a deprecation logic to be added.blocks-gallery-image- this is already used in deprecation logicHow has this been tested?
Manually.
Types of changes
No visual changes.
Checklist: