Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Address stalling Android E2E test tasks #66771

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Nov 5, 2024

What?

Address recently indefinite hanging that occurs while terminating the emulator for the Android end-to-end test CI tasks.

Why?

The CI tasks never complete, so a successful test suite run is never reported, which blocks the pull request status and causes confusion.

How?

Remove the recommended AVD cache, as it appears its presence can cause indefinite hangs while terminating the emulator, as referenced several times in the reactivecircus/android-emulator-runner issue tracker:

It is possible that removing the AVD cache is somewhat of an ineffective fix—temporarily solving the issue in the form of removing a problematic cache—but, given numerous other people report the AVD cache as problematic, I figure removing the AVD cache is worth a try.

Testing Instructions

N/A, no user-facing changes.

Testing Instructions for Keyboard

N/A, no user-facing changes.

Screenshots or screencast

N/A, no user-facing changes.

@dcalhoun dcalhoun added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Nov 5, 2024
@dcalhoun dcalhoun changed the title ci: Increase AVD cache key specificity ci: Address stalling Android E2E test tasks Nov 5, 2024
Avoid erroneous cache hits that may result in the CI task hanging
indefinitely while terminating the emulator.
Attempt to resolve indefinitely hanging Android E2E test tasks.
AVD cache disabled as it caused emulator termination to hang
indefinitely.
@dcalhoun dcalhoun force-pushed the ci/address-stalling-android-e2e-test-task branch from c5df543 to cfa7b81 Compare November 5, 2024 20:58
Copy link

github-actions bot commented Nov 5, 2024

Flaky tests detected in cfa7b81.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11692403211
📝 Reported issues:

@dcalhoun dcalhoun marked this pull request as ready for review November 5, 2024 21:41
@dcalhoun dcalhoun requested a review from desrosj as a code owner November 5, 2024 21:41
Copy link

github-actions bot commented Nov 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@dcalhoun dcalhoun requested a review from ellatrix November 5, 2024 21:55
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dcalhoun!

Let's give it a try!

@Mamaduka Mamaduka merged commit 471e4bd into trunk Nov 6, 2024
67 checks passed
@Mamaduka Mamaduka deleted the ci/address-stalling-android-e2e-test-task branch November 6, 2024 05:17
@github-actions github-actions bot added this to the Gutenberg 19.7 milestone Nov 6, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
* ci: Increase AVD cache key specificity

Avoid erroneous cache hits that may result in the CI task hanging
indefinitely while terminating the emulator.

* Revert "ci: Increase AVD cache key specificity"

This reverts commit 2e892a6.

* ci: Update Android test runner to macOS 13

Attempt to resolve indefinitely hanging Android E2E test tasks.

* Revert "ci: Update Android test runner to macOS 13"

This reverts commit a4c844d.

* ci: Disable AVD cache

AVD cache disabled as it caused emulator termination to hang
indefinitely.

Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants