Media Utils: add experimental sideloadMedia
#66378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Enhancement
|
Size Change: +301 B (+0.02%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
swissspidy
force-pushed
the
add/61447-sideloadmedia
branch
from
f50488a to
e614108
Compare
swissspidy
force-pushed
the
add/61447-sideloadmedia
branch
from
e614108 to
d969b0b
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
swissspidy
requested review from
gziolo,
ntsekouras,
sirreal,
gigitux and
youknowriad
|
FWIW this should be an easy one to review :-) Would unblock some of the other ongoing work regarding client-side media processing |
|
Flaky tests detected in 0a323f2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11660572586
|
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a new addition for the experimental client-side media processing, see #61447. That's why the code is behind a private API for now.
This code has been tested extensively as part of swissspidy/media-experiments.
Builds on top of #64784 and #64650
Why?
Required for the client-side media processing experiment
How?
Testing Instructions
Unit tests should pass
Testing Instructions for Keyboard
Screenshots or screencast