-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use npm v6 is the minimum required version #6629
Conversation
I'm fine with the change, given that I'm already using v6.x locally :) |
Good call @gziolo, upon checking the docs already state to use the latest npm:
|
|
Good docs, by the way. Future proof :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
No, npm use |
Since #6629, npm 6 in the minimum version, so install it at setup time.
Since #6629, npm 6 in the minimum version, so install it at setup time.
npm 6 is not even provided by https://github.com/nodesource/distributions (5.6 is) After fixing
which was solved by |
Description
Updates the minimum required version of npm to version
6.0.0
or greater.This is a follow up to #6610 (comment) where npm v6.0.0 was used to generate the
package-lock.json
file, everyone should be using the same version of npm otherwise there will be unnecessary and potentially troublesome pull requests submitted due to the differences in how npm v5 and v6 handlepackage-lock.json
files.How has this been tested?
Screenshots
Types of changes
Build tool update
Checklist: