Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated several typos in client-assets.php file #66084

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

shail-mehta
Copy link
Member

Updated several typos in lib/client-assets.php file

  • replalce it should be replace
  • devlopment it should be development

@shail-mehta shail-mehta added the [Type] Developer Documentation Documentation for developers label Oct 13, 2024
@shail-mehta shail-mehta self-assigned this Oct 13, 2024
Copy link

github-actions bot commented Oct 13, 2024

Flaky tests detected in 7df7de6.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11350531732
📝 Reported issues:

@shail-mehta shail-mehta marked this pull request as ready for review October 13, 2024 05:06
Copy link

github-actions bot commented Oct 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta requested a review from sirreal October 13, 2024 05:06
@t-hamano t-hamano self-requested a review October 13, 2024 10:14
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This change is also necessary in the core, so could you take the following steps according to the README?

  • Submit a ticket on Trac
  • Submit a PR to wordpress-develop repo
  • Add the markdown files to backport-changelog/6.8/{CORE_PR_NUMBER}.md and update this PR

@shail-mehta
Copy link
Member Author

@mukeshpanchal27 @t-hamano Thank you for the review.

@shail-mehta
Copy link
Member Author

shail-mehta commented Oct 13, 2024

@t-hamano Thank you for the steps.

I have created ticket in core: https://core.trac.wordpress.org/ticket/62213

Here is Pull Request URL in wordpress-develop repo: WordPress/wordpress-develop#7561

@shail-mehta
Copy link
Member Author

shail-mehta commented Oct 14, 2024

@t-hamano Core PR is Merged in 6.7, so i need to change in backport changelog in gutenberg in 6.7 instead of 6.8?

@t-hamano
Copy link
Contributor

Thanks for the update!

Core PR is Merged in 6.7, so i need to change in backport changelog in gutenberg in 6.7 instead of 6.8?

Yes, the core ticket certainly appears to apply to WP 6.7. Could you move the changelog file to the 6.7 directory?

@shail-mehta
Copy link
Member Author

shail-mehta commented Oct 15, 2024

Thanks for the update!

Core PR is Merged in 6.7, so i need to change in backport changelog in gutenberg in 6.7 instead of 6.8?

Yes, the core ticket certainly appears to apply to WP 6.7. Could you move the changelog file to the 6.7 directory?

@t-hamano Updated. (Moved changelog in 6.7 instead of 6.8)

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update.

@shail-mehta shail-mehta merged commit 0ee8ce4 into trunk Oct 16, 2024
64 checks passed
@shail-mehta shail-mehta deleted the update/several-typos branch October 16, 2024 02:06
@github-actions github-actions bot added this to the Gutenberg 19.5 milestone Oct 16, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
* Updated several typos in client-assets.php file

* updated in backport changelog

* moved changelog file in 6.7 folder
---------

Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants