-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated several typos in client-assets.php file #66084
Conversation
Flaky tests detected in 7df7de6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11350531732
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
This change is also necessary in the core, so could you take the following steps according to the README?
- Submit a ticket on Trac
- Submit a PR to
wordpress-develop
repo - Add the markdown files to
backport-changelog/6.8/{CORE_PR_NUMBER}.md
and update this PR
@mukeshpanchal27 @t-hamano Thank you for the review. |
@t-hamano Thank you for the steps. I have created ticket in core: https://core.trac.wordpress.org/ticket/62213 Here is Pull Request URL in wordpress-develop repo: WordPress/wordpress-develop#7561 |
@t-hamano Core PR is Merged in 6.7, so i need to change in backport changelog in gutenberg in 6.7 instead of 6.8? |
Thanks for the update!
Yes, the core ticket certainly appears to apply to WP 6.7. Could you move the changelog file to the |
cab0f38
to
9b92b68
Compare
@t-hamano Updated. (Moved changelog in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the update.
* Updated several typos in client-assets.php file * updated in backport changelog * moved changelog file in 6.7 folder --------- Co-authored-by: shail-mehta <shailu25@git.wordpress.org> Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Updated several typos in lib/client-assets.php file
replalce
it should bereplace
devlopment
it should bedevelopment