Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom out: fix scaling issues #65998

Merged
merged 12 commits into from
Oct 10, 2024
Merged

Zoom out: fix scaling issues #65998

merged 12 commits into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. changed from using borders to use pseudo elements

    @MaggieCabrera @jeryj
    MaggieCabrera authored and jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6dcea75 View commit details
    Browse the repository at this point in the history

  2. added comments

    @MaggieCabrera @jeryj
    MaggieCabrera authored and jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    53fe5ab View commit details
    Browse the repository at this point in the history

  3. Include frame size in the scaling calculation 

    Instead of adding the frame size as a border (which causes reflow issues), include the frame size in the scaling calculation so there's always a left/right gutter of the frame size.
    @jeryj
    jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    22587a1 View commit details
    Browse the repository at this point in the history

  4. Account for scaling in the frame height

    @jeryj
    jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7dfed11 View commit details
    Browse the repository at this point in the history

  5. Calculation in CSS

    @ajlende @jeryj
    ajlende authored and jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    abe17a2 View commit details
    Browse the repository at this point in the history

  6. Revert "Calculation in CSS" 

    This reverts commit 38de9fc.
    @jeryj
    jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c70f39a View commit details
    Browse the repository at this point in the history

  7. Add comment about why the calculation for scaling needs to happen in … 

    …the JS
    @jeryj
    jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a444cdb View commit details
    Browse the repository at this point in the history

  8. Force px value for frameSize

    @jeryj
    jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7af85bd View commit details
    Browse the repository at this point in the history

  9. Restore previous frameSize var setting

    @jeryj
    jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4146bd3 View commit details
    Browse the repository at this point in the history

  10. Add back line break

    @jeryj
    jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    28e4dd0 View commit details
    Browse the repository at this point in the history

  11. Use padding top/bottom instead of before/after for top/bottom frame

    @jeryj
    jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    03ed997 View commit details
    Browse the repository at this point in the history

  12. Remove more before/after css since we are using padding

    @jeryj
    jeryj committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    47b31ed View commit details
    Browse the repository at this point in the history