Backport #63611 to 6.7 #65971
Merged
Backport #63611 to 6.7 #65971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Focus] Accessibility (a11y)
afercia
requested review from
draganescu,
adamziel and
kevin940726
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -286 B (-0.02%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Oct 11, 2024
packages/interface/CHANGELOG.md
Outdated
| @@ -2,6 +2,12 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Breaking Changes | |||
There was a problem hiding this comment.
I'm not entirely sure it's helpful when publishing with dist-tag=wp-6.7. The version bump will be from 6.8.5 to 6.8.6:
The changelog won't get updated. So if we want to keep any log, it should be listed as Bug Fix under 6.8.6 section.
getdave
reviewed
Oct 11, 2024
getdave
reviewed
Oct 11, 2024
packages/interface/CHANGELOG.md
Outdated
Comment on lines
3
to
7
| ## 6.8.6 (2024-10-11) | ||
|
|
||
| ### Bug fix | ||
|
|
||
| - `InterfaceSkeleton` no longer supports region navigation and its props `enableRegionNavigation` and `shortcuts` are removed. ([#63611](https://github.com/WordPress/gutenberg/pull/63611)). It’s recommended to add region navigation with the higher-order component `navigateRegions` or the hook `__unstableUseNavigateRegions` from `@wordpress/components`. |
There was a problem hiding this comment.
@gziolo How does this look to you now?
kevin940726
approved these changes
Oct 11, 2024
* Avoid to pass unnecessary props to useNavigateRegions. * Remove bubblesVirtually from WP logo slot. * Restore bubblesVirtually. * Move useNavigateRegions to an outermost ancestor. * Remove no longer used enableRegionNavigation prop. * Add changelog entry --------- Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
kevin940726
force-pushed
the
backport/63611
branch
from
35cd438 to
3f791b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually fixes conflicts (in the CHANGELOG) and backports #63611 to the 6.7 release.
Cc @aaronrobertshaw