Global style revisions: remove unnecessary goTo navigation call
#65810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `Navigator.BackButton` already has default back behaviour.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 657b5f1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11135870136
|
Mamaduka
added
the
Global Styles
Mamaduka
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Thank you, @ramonjd! The back navigation works as before.
Side note: I noticed that when I open the Style Book and then the Revisions, the panel does some kind of double rendering/navigation. It could be worth tracking this separately.
Screencast
CleanShot.2024-10-02.at.08.09.10.mp4
Thanks @Mamaduka I'm sure this or something similar came up somewhere else, but now I can't find it 🤔 |
Might be related: |
|
Thanks for fixing this up! |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…rdPress#65810) Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…call (WordPress#65810)" This reverts commit 7b5f4b2.
draganescu
pushed a commit
that referenced
this pull request
Oct 2, 2024
…5810) Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? How? Why?
Partly addresses #65794
Remove
goTo()call in theonBackcallback for the ScreenHeader sinceNavigator.BackButtonalready has default back behaviour.Testing Instructions
Head over to Global styles revisions.
Check that the header back button returns to the root styles panel.
Screenshots or screencast
2024-10-02.10.39.44.mp4