-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Bindings: Add @since
tag in bindings apis JSDocs
#65796
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Does this need the |
_Changelog_ | ||
|
||
`6.7.0` Introduced in WordPress core. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed what is done in other functions like this one: https://github.com/WordPress/gutenberg/blob/0e17bd28ac8adf8612b9daa2b1d30e1961b7c58d/packages/element/README.md#hydrateroot
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good 👍
No, the developer docs are sourced from trunk. |
Nice update. 👍 |
…5796) * Add tag to `useBlockBindingsUtils` * Add since tag to the registration functions Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
…dPress#65796)" This reverts commit a9350e2.
* Add tag to `useBlockBindingsUtils` * Add since tag to the registration functions Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
What?
As suggested here, I'm exploring how it would look like introducing the
@since
tag to the exposed bindings APIs.Why?
It could help track which APIs are available in each release.
How?
I just added the
@since
tag and generated the docs.Testing Instructions
Nothing should be affected. Tests should pass.