Tweak entity save panel button #65695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
added
the
Backport to WP 6.7 Beta/RC
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fa1ecca. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11067509714
|
jasmussen
approved these changes
Sep 27, 2024
|
Thanks for the review! |
github-actions
bot
added
Backported to WP Core
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 27, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: bf83960 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #65317
What?
This PR makes three changes to the entity save panels for the global styles:
Why?
In #65317, the position of the pre-publish buttons was reversed:
The entity save panel buttons in the site editor are in the opposite position to this, which is a bit confusing.
How?
I've adjusted it so that it has the exact same layout as the pre-publish button.
Testing Instructions
Testing Instructions for Keyboard
Test the same steps using only the keyboard.
Screenshots or screencast
Before
After