Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Pagination: Add previous and next link block examples #65633

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

aaronrobertshaw
Copy link
Contributor

Part of: #64707
Related: #65430

What?

Adds block example definitions for the Comment Pagination Previous/Next blocks.

Why?

The Style Book is being iterated on and part of that effort is to ensure the desired blocks are shown there. Currently, this is dependent on blocks having an example defined.

How?

  • Adds an example to the Comment Pagination Previous block.
  • Adds an example to the Comment Pagination Next block.

Testing Instructions

  1. Navigate to the Style Book, (Appearance > Editor > Styles > Style Book icon) and switch to the "Theme" tab.
  2. Confirm block examples display for both the Comment Pagination Previous and Next blocks.
  3. Insert a Comments block, select it, then click the quick inserter.
  4. In the insert popover, select Browse All to open the main inserter, then search for Comment Pagination
  5. Confirm the example displays in the preview for the Comment Pagination Previous/Next blocks

Screenshots or screencast

Screenshot 2024-09-25 at 4 05 59 pm Screenshot 2024-09-25 at 4 05 38 pm Screenshot 2024-09-25 at 4 05 32 pm

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Comments Pagination Previous Affects the Comments Pagination Previous Block [Block] Comment Pagination Next Affects the Comments Pagination Next Block labels Sep 25, 2024
@aaronrobertshaw aaronrobertshaw self-assigned this Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐋

Style book Next Prev
Screenshot 2024-09-25 at 4 16 23 pm Screenshot 2024-09-25 at 4 16 13 pm Screenshot 2024-09-25 at 4 16 09 pm

@aaronrobertshaw aaronrobertshaw merged commit 02a884f into trunk Sep 25, 2024
70 checks passed
@aaronrobertshaw aaronrobertshaw deleted the add/comment-next-previous-block-examples branch September 25, 2024 07:12
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comment Pagination Next Affects the Comments Pagination Next Block [Block] Comments Pagination Previous Affects the Comments Pagination Previous Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants